Skip to content

Add command-line option "dns-cache-size" for trust-dns #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2023
Merged

Add command-line option "dns-cache-size" for trust-dns #1229

merged 4 commits into from
Jun 27, 2023

Conversation

@zedifen
Copy link
Contributor

@zedifen zedifen commented Jun 22, 2023 •
edited
Loading

See also #1215

This PR adds a command-line option --dns-cache-size to sslocal, ssserver and ssmanager, allowing users to configure the cache_size of ResolverOpts in trust-dns.

I'm not sure if the current solution is appropriate, i.e. to pass dns_cache_size all the way to create_resolver. How about I pass the dns_cache_size through a ResolverOpts?

@zonyitoo
Copy link
Collaborator

zonyitoo commented Jun 22, 2023

Please check the clippy logs and fix those warnings.

zedifen
zedifen commented Jun 23, 2023
View reviewed changes
Copy link
Contributor Author

@zedifen zedifen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve code

@fernvenue
Copy link
Contributor

fernvenue commented Jun 23, 2023

Maybe mention this change in README?

@zonyitoo
Copy link
Collaborator

zonyitoo commented Jun 23, 2023

Maybe mention this change in README?

Sounds great!

@zedifen zedifen changed the title Add command-line option for "dns-cache-size" Add command-line option "dns-cache-size" for trust-dns Jun 23, 2023
@fernvenue
Copy link
Contributor

fernvenue commented Jun 24, 2023

Tested, works great :)

zonyitoo
zonyitoo requested changes Jun 25, 2023
View reviewed changes
@zedifen zedifen requested a review from zonyitoo June 25, 2023 12:09
@zedifen
Copy link
Contributor Author

zedifen commented Jun 26, 2023 •
edited
Loading

I'm going to rebase this branch 😊

Update: rebased.

@zedifen
Copy link
Contributor Author

zedifen commented Jun 26, 2023

Oh, by the way, currently the musl cross-build would fail on stable rust toolchain with recent ziglang versions. Moving to rust nightly would fix it.

Or, the rust is going to stabilize the new musl version shipped with the toolchain in 1.71. See https://blog.rust-lang.org/2023/05/09/Updating-musl-targets.html

One may refer to the PR in my fork of the repository. https://github.com/zedifen/shadowsocks-rust/pull/4

@zonyitoo zonyitoo merged commit fb2192b into shadowsocks:master Jun 27, 2023
@zonyitoo
Copy link
Collaborator

zonyitoo commented Jun 27, 2023

I am still waiting trust-dns to stablize its new version, so it is Ok to wait 1.71 until making the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonyitoo zonyitoo Awaiting requested review from zonyitoo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zedifen @zonyitoo @fernvenue